Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Howard Hughes Medical Institute 2023.csl #6615

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

michavissar
Copy link
Contributor

This is a house citation style for the Howard Hughes Medical Institute created in 2023.

This is a house citation style for the Howard Hughes Medical Institute created in 2023.
Copy link
Member

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the automated validation report isn't showing. Sorry about that.

Left several comments to fix. Also, please be sure your style validates by running it through

https://validator.citationstyles.org/

<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" demote-non-dropping-particle="never" default-locale="en-US">
<!-- This style was edited with the Visual CSL Editor (https://editor.citationstyles.org/visualEditor/) -->
<info>
<title>Howard Hughes Medical Institute 2023</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<title>Howard Hughes Medical Institute 2023</title>
<title>Howard Hughes Medical Institute</title>

Howard Hughes Medical Institute 2023.csl Outdated Show resolved Hide resolved
<info>
<title>Howard Hughes Medical Institute 2023</title>
<id>http://www.zotero.org/styles/hhmi</id>
<link rel="self" href="http://www.zotero.org/styles/hhmi"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link rel="self" href="http://www.zotero.org/styles/hhmi"/>
<link rel="self" href="http://www.zotero.org/styles/howard-hughes-medical-institute"/>

<layout>
<group>
<text macro="author" suffix="."/>
<group prefix=". ">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems to be missing here

</layout>
</citation>
<bibliography hanging-indent="true" entry-spacing="0" line-spacing="1">
<text variable="citation-number" suffix=". "/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go in the <layout> section below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Struggling with this one a bit - can you explain where exactly this should go in the <layout> section? Every time I try to move it, I get an error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that prints something needs to be somehwere between <layout> and </layout>. In this case, I'd guess this should go right below <layout>, i.e. in line 121, but that depends, of course, on exactly how you want things to look.

Copy link
Contributor Author

@michavissar michavissar Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for my confusion (I'm a complete n00b and this is a one-off project). Initially, this comment seemed to be referring to lines 112-115, but now I'm seeing a much larger block of code. Can you clarify which lines need to move?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 115 — the citation-number text line.

<group>
<text macro="author" suffix="."/>
<group prefix=". ">
<text macro="title" suffix="."/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, avoid prefixes and suffixes as a method to add delimiters like this--it will lead to erroneous punctuation being added if an item is missing some piece of data such as a title. Instead, use a <group> with delimiter=". " or similar.

@adam3smith
Copy link
Member

Also, see https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md which includes most of the points bwiernik mentions and fix the rights section. It needs to be exactly as listed there; your text differs slightly.

Also, don't use validator.nu -- use our custom validator at https://validator.citationstyles.org/

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 2, 2023
@michavissar
Copy link
Contributor Author

Thanks so much for all the help @adam3smith and @bwiernik . Greatly appreciated!

@michavissar michavissar closed this Aug 2, 2023
@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 2, 2023
@github-actions github-actions bot reopened this Aug 2, 2023
@adam3smith
Copy link
Member

(Please updated this PR instead of opening a new one)

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 2, 2023
@michavissar
Copy link
Contributor Author

Oops, I moved too quickly. I've close the new one now. I made a number of changes beyond those listed here. Can you explain how I replace the old code with the new one for review?

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 2, 2023
@adam3smith
Copy link
Member

Can you explain how I replace the old code with the new one for review?

Click on "Files Changed", then on the three-dots menu on the right and edit file, delete the old code and replace with the new one. You can have github show you a preview of your changes before committing.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 2, 2023
@adam3smith
Copy link
Member

The failing check here is some technical glitch, don't worry about it.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

howard-hughes-medical-institute.csl (new)
1,2
3,4

1. CSL search by example. (2012)
2. Fenner M, Crosas M, Grethe J S, Kennedy D, Hermjakob H, Rocca-Serra P, Durand G, Berjon R, Karcher S, Martone M, and Clark T. A data citation roadmap for scholarly data repositories. (2019) DOI: http://doi.org/10.1038/s41597-019-0031-8
3. Hancké B, Rhodes M, and Thatcher M, editors. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. (2007) ISBN: 978-0-19-920648-3
4. Mares I. Firms and the welfare state: When, why, and how does social policy matter to employers? (2001)

@adam3smith
Copy link
Member

@michavissar -- please confirm that the preview above looks right & we can merge

@michavissar
Copy link
Contributor Author

@michavissar -- please confirm that the preview above looks right & we can merge

Everything looks good - thank you!

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 8, 2023
@adam3smith adam3smith merged commit 18ee055 into citation-style-language:master Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants